jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ee90f72a76ca0ae2b5f8dd815a59fd502ab966ae
commit ee90f72a76ca0ae2b5f8dd815a59fd502ab966ae Author: Jean-Philippe Andre <[email protected]> Date: Tue Nov 7 14:03:19 2017 +0900 elm: Call efl_access_type_set after construction I don't think it is necessary to call this before construction, and that could instead lead to issues. It's just weird overall. --- src/lib/elementary/efl_ui_bg.c | 2 +- src/lib/elementary/efl_ui_box.c | 2 +- src/lib/elementary/elm_box.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/elementary/efl_ui_bg.c b/src/lib/elementary/efl_ui_bg.c index a1afbeed56..7bb9e8bd9b 100644 --- a/src/lib/elementary/efl_ui_bg.c +++ b/src/lib/elementary/efl_ui_bg.c @@ -120,9 +120,9 @@ elm_bg_add(Evas_Object *parent) EOLIAN static Eo * _efl_ui_bg_efl_object_constructor(Eo *obj, Efl_Ui_Bg_Data *_pd EINA_UNUSED) { - efl_access_type_set(obj, EFL_ACCESS_TYPE_DISABLED); obj = efl_constructor(efl_super(obj, MY_CLASS)); efl_canvas_object_type_set(obj, MY_CLASS_NAME_LEGACY); + efl_access_type_set(obj, EFL_ACCESS_TYPE_DISABLED); efl_ui_widget_focus_allow_set(obj, EINA_FALSE); diff --git a/src/lib/elementary/efl_ui_box.c b/src/lib/elementary/efl_ui_box.c index 7c6fdeb123..9274b5666b 100644 --- a/src/lib/elementary/efl_ui_box.c +++ b/src/lib/elementary/efl_ui_box.c @@ -158,10 +158,10 @@ _efl_ui_box_efl_canvas_group_group_del(Eo *obj, Efl_Ui_Box_Data *sd) EOLIAN static Eo * _efl_ui_box_efl_object_constructor(Eo *obj, Efl_Ui_Box_Data *pd) { - efl_access_type_set(obj, EFL_ACCESS_TYPE_SKIPPED); obj = efl_constructor(efl_super(obj, MY_CLASS)); efl_canvas_object_type_set(obj, MY_CLASS_NAME); evas_object_smart_callbacks_descriptions_set(obj, _smart_callbacks); + efl_access_type_set(obj, EFL_ACCESS_TYPE_SKIPPED); efl_access_role_set(obj, EFL_ACCESS_ROLE_FILLER); pd->align.h = 0.5; diff --git a/src/lib/elementary/elm_box.c b/src/lib/elementary/elm_box.c index 10ede30361..b59705d861 100644 --- a/src/lib/elementary/elm_box.c +++ b/src/lib/elementary/elm_box.c @@ -372,10 +372,10 @@ elm_box_add(Evas_Object *parent) EOLIAN static Eo * _elm_box_efl_object_constructor(Eo *obj, Elm_Box_Data *_pd EINA_UNUSED) { - efl_access_type_set(obj, EFL_ACCESS_TYPE_SKIPPED); obj = efl_constructor(efl_super(obj, MY_CLASS)); efl_canvas_object_type_set(obj, MY_CLASS_NAME_LEGACY); evas_object_smart_callbacks_descriptions_set(obj, _smart_callbacks); + efl_access_type_set(obj, EFL_ACCESS_TYPE_SKIPPED); efl_access_role_set(obj, EFL_ACCESS_ROLE_FILLER); return obj; --
