raster pushed a commit to branch efl-1.20. http://git.enlightenment.org/core/efl.git/commit/?id=81ef814cdb88850fc8d1d5b89c941309902959c8
commit 81ef814cdb88850fc8d1d5b89c941309902959c8 Author: Daniel Kolesa <[email protected]> Date: Fri Oct 13 23:48:34 2017 +0200 eolian: fix setter generation for @auto functions Because of a typo in generator source (and overlooked error in tests) we were previously generating incorrect code for setters with the @auto qualifier. This was brought up in D5306 and is now fixed. --- src/bin/eolian/sources.c | 2 +- src/tests/eolian/data/override_ref.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bin/eolian/sources.c b/src/bin/eolian/sources.c index d1ab3d5870..097293add0 100644 --- a/src/bin/eolian/sources.c +++ b/src/bin/eolian/sources.c @@ -281,7 +281,7 @@ _gen_func(const Eolian_Unit *src, const Eolian_Class *cl, if (is_auto) { if (ftype == EOLIAN_PROP_SET) - eina_strbuf_append_printf(params_init, " %s = pd->%s;\n", prn, prn); + eina_strbuf_append_printf(params_init, " pd->%s = %s;\n", prn, prn); else { eina_strbuf_append_printf(params_init, " if (%s) *%s = pd->%s;\n", diff --git a/src/tests/eolian/data/override_ref.c b/src/tests/eolian/data/override_ref.c index 967914a09d..95ee937ae0 100644 --- a/src/tests/eolian/data/override_ref.c +++ b/src/tests/eolian/data/override_ref.c @@ -6,9 +6,9 @@ EOAPI EFL_VOID_FUNC_BODY_CONST(override_a_get); static void __eolian_override_b_set(Eo *obj EINA_UNUSED, Override_Data *pd, int idx EINA_UNUSED, float a, char b, int c) { - a = pd->a; - b = pd->b; - c = pd->c; + pd->a = a; + pd->b = b; + pd->c = c; } EOAPI EFL_VOID_FUNC_BODYV(override_b_set, EFL_FUNC_CALL(idx, a, b, c), int idx, float a, char b, int c); @@ -42,9 +42,9 @@ void _override_base_constructor(Eo *obj, Override_Data *pd); static void __eolian_override_base_z_set(Eo *obj EINA_UNUSED, Override_Data *pd, int a, char b, float c) { - a = pd->a; - b = pd->b; - c = pd->c; + pd->a = a; + pd->b = b; + pd->c = c; } --
