raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=be6f4a870a667974280332ba6693e1223ec51dc5
commit be6f4a870a667974280332ba6693e1223ec51dc5
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Fri Nov 24 23:45:14 2017 +0900
efl ui slider - fix crashes with fmt callback data and class data
the format free cb was passed the class data (sd) as the callback data
but this was freed by the time _indi_default_format_free_cb was called
causing an invalid access. fix this by looking it up from the obj
which is probably invalid at this point...
---
src/lib/elementary/efl_ui_slider.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/elementary/efl_ui_slider.c
b/src/lib/elementary/efl_ui_slider.c
index 1bc9ec9290..b5da71ef2a 100644
--- a/src/lib/elementary/efl_ui_slider.c
+++ b/src/lib/elementary/efl_ui_slider.c
@@ -1421,7 +1421,7 @@ static void
_indi_default_format_cb(void *data, Eina_Strbuf *str, const Eina_Value value)
{
const Eina_Value_Type *type = eina_value_type_get(&value);
- Efl_Ui_Slider_Data *sd = data;
+ Efl_Ui_Slider_Data *sd = efl_data_scope_get(data, EFL_UI_SLIDER_CLASS);
double v;
if (type != EINA_VALUE_TYPE_DOUBLE) return;
@@ -1433,7 +1433,7 @@ _indi_default_format_cb(void *data, Eina_Strbuf *str,
const Eina_Value value)
static void
_indi_default_format_free_cb(void *data)
{
- Efl_Ui_Slider_Data *sd = data;
+ Efl_Ui_Slider_Data *sd = efl_data_scope_get(data, EFL_UI_SLIDER_CLASS);
if (sd && sd->indi_template)
{
@@ -1451,7 +1451,7 @@ _efl_ui_slider_part_efl_ui_format_format_string_set(Eo
*obj, void *_pd EINA_UNUS
if (!template) return;
eina_stringshare_replace(&sd->indi_template, template);
- efl_ui_format_cb_set(efl_part(pd->obj, "indicator"), sd,
_indi_default_format_cb, _indi_default_format_free_cb);
+ efl_ui_format_cb_set(efl_part(pd->obj, "indicator"), pd->obj,
_indi_default_format_cb, _indi_default_format_free_cb);
}
EOLIAN static const char *
--
