devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=3cd4a5e77f1816356552e5fbce8015ebe1649135
commit 3cd4a5e77f1816356552e5fbce8015ebe1649135 Author: Chris Michael <[email protected]> Date: Mon Dec 11 14:51:09 2017 -0500 elementary: Fix resource leak Coverity reports a resource leak here. According to eina_strbuf documentation, the result of eina_strbuf_release should be free'd when not needed anymore. Fixes Coverity CID1383551 @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/elementary/efl_ui_progressbar.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lib/elementary/efl_ui_progressbar.c b/src/lib/elementary/efl_ui_progressbar.c index 3f0683a331..13138339fc 100644 --- a/src/lib/elementary/efl_ui_progressbar.c +++ b/src/lib/elementary/efl_ui_progressbar.c @@ -352,6 +352,7 @@ EOLIAN static void _efl_ui_progressbar_efl_canvas_group_group_add(Eo *obj, Efl_Ui_Progressbar_Data *priv) { ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd); + char *group; if (!elm_widget_theme_klass_get(obj)) elm_widget_theme_klass_set(obj, "progressbar"); @@ -361,12 +362,16 @@ _efl_ui_progressbar_efl_canvas_group_group_add(Eo *obj, Efl_Ui_Progressbar_Data priv->dir = EFL_UI_DIR_RIGHT; priv->val = MIN_RATIO_LVL; + group = _efl_ui_progressbar_theme_group_get(obj, priv); + if (!elm_widget_theme_object_set(obj, wd->resize_obj, elm_widget_theme_klass_get(obj), - _efl_ui_progressbar_theme_group_get(obj, priv), + group elm_widget_theme_style_get(obj))) CRI("Failed to set layout!"); + free(group); + efl_ui_format_string_set(obj, "%.0f %%"); priv->spacer = evas_object_rectangle_add(evas_object_evas_get(obj)); --
