devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=18429454326150e45560354f19c553694ba5b45e

commit 18429454326150e45560354f19c553694ba5b45e
Author: Chris Michael <[email protected]>
Date:   Mon Dec 11 14:47:14 2017 -0500

    elementary: Fix resource leak
    
    Coverity reports a resource leak here. According to eina_strbuf
    documentation, the result of eina_strbuf_release should be free'd when
    not needed anymore.
    
    Fixes Coverity CID1383549
    
    @fix
    
    Signed-off-by: Chris Michael <[email protected]>
---
 src/lib/elementary/efl_ui_panes.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_panes.c 
b/src/lib/elementary/efl_ui_panes.c
index b98a1ee26c..f215387185 100644
--- a/src/lib/elementary/efl_ui_panes.c
+++ b/src/lib/elementary/efl_ui_panes.c
@@ -390,18 +390,22 @@ _efl_ui_panes_efl_canvas_group_group_add(Eo *obj, 
Efl_Ui_Panes_Data *_pd EINA_UN
 {
    ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd);
    EFL_UI_PANES_DATA_GET(obj, sd);
+   char *group;
 
    if (!elm_widget_theme_klass_get(obj))
      elm_widget_theme_klass_set(obj, "panes");
    efl_canvas_group_add(efl_super(obj, MY_CLASS));
    elm_widget_sub_object_parent_add(obj);
 
+   group = _efl_ui_panes_theme_group_get(obj, sd);
    if (!elm_widget_theme_object_set(obj, wd->resize_obj,
                                        elm_widget_theme_klass_get(obj),
-                                       _efl_ui_panes_theme_group_get(obj, sd),
+                                       group,
                                        elm_widget_theme_style_get(obj)))
      CRI("Failed to set layout!");
 
+   free(group);
+
    elm_panes_content_left_size_set(obj, 0.5);
 
    edje_object_signal_callback_add

-- 


Reply via email to