devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=af4af300af748f9090971409f733bff641537469
commit af4af300af748f9090971409f733bff641537469 Author: Chris Michael <[email protected]> Date: Thu Dec 14 07:35:07 2017 -0500 eeze: Remove unused device variables As we do not ever use the udev_devices created from udev_device_new_from_syspath in these functions, remove them. @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/eeze/eeze_udev_find.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/lib/eeze/eeze_udev_find.c b/src/lib/eeze/eeze_udev_find.c index 35cdbe83c5..3b1e5ef926 100644 --- a/src/lib/eeze/eeze_udev_find.c +++ b/src/lib/eeze/eeze_udev_find.c @@ -328,7 +328,6 @@ eeze_udev_find_by_filter(const char *subsystem, { _udev_enumerate *en; _udev_list_entry *devs, *cur; - _udev_device *device; const char *devname; Eina_List *ret = NULL; @@ -350,15 +349,11 @@ eeze_udev_find_by_filter(const char *subsystem, udev_list_entry_foreach(cur, devs) { devname = udev_list_entry_get_name(cur); - device = udev_device_new_from_syspath(udev, devname); - if (name) - if (!strstr(devname, name)) - goto out; + if (name && (!strstr(devname, name))) + continue; ret = eina_list_append(ret, eina_stringshare_add(devname)); -out: - udev_device_unref(device); } udev_enumerate_unref(en); return ret; @@ -370,7 +365,6 @@ eeze_udev_find_by_sysattr(const char *sysattr, { _udev_enumerate *en; _udev_list_entry *devs, *cur; - _udev_device *device; const char *devname; Eina_List *ret = NULL; @@ -388,9 +382,7 @@ eeze_udev_find_by_sysattr(const char *sysattr, udev_list_entry_foreach(cur, devs) { devname = udev_list_entry_get_name(cur); - device = udev_device_new_from_syspath(udev, devname); ret = eina_list_append(ret, eina_stringshare_add(devname)); - udev_device_unref(device); } udev_enumerate_unref(en); return ret; @@ -401,7 +393,6 @@ eeze_udev_find_by_subsystem_sysname(const char *subsystem, const char *sysname) { _udev_enumerate *en; _udev_list_entry *devs, *cur; - _udev_device *device; const char *devname; Eina_List *ret = NULL; @@ -416,10 +407,7 @@ eeze_udev_find_by_subsystem_sysname(const char *subsystem, const char *sysname) udev_list_entry_foreach(cur, devs) { devname = udev_list_entry_get_name(cur); - device = udev_device_new_from_syspath(udev, devname); - if (!device) continue; ret = eina_list_append(ret, eina_stringshare_add(devname)); - udev_device_unref(device); } udev_enumerate_unref(en); return ret; --
