stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=59520a57cb33266974d7a51c96bcd208fc7c94ca
commit 59520a57cb33266974d7a51c96bcd208fc7c94ca
Author: Mike Blumenkrantz <zm...@osg.samsung.com>
Date: Mon Apr 9 13:36:56 2018 +0200
tests: remove extra download in ecore_test_ecore_file_download
Summary:
this function is just a wrapper, avoid downloading the same file
multiple times
ref T6853
Depends on D5885
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6853
Differential Revision: https://phab.enlightenment.org/D5886
---
src/tests/ecore/ecore_test_ecore_file.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/src/tests/ecore/ecore_test_ecore_file.c
b/src/tests/ecore/ecore_test_ecore_file.c
index 118d359504..764d0073f9 100644
--- a/src/tests/ecore/ecore_test_ecore_file.c
+++ b/src/tests/ecore/ecore_test_ecore_file.c
@@ -497,16 +497,6 @@ EFL_START_TEST(ecore_test_ecore_file_download)
strcat(dest_name, download_dir);
strcat(dest_name, "/");
strcat(dest_name, download_file);
- res = ecore_file_download(download_url, dest_name, completion_cb,
- progress_cb, NULL, &job);
- fail_if(res != EINA_TRUE);
- fail_if(!job);
- ecore_main_loop_begin();
- fprintf(stderr, "Downloaded %lld bytes\n", ecore_file_size(dest_name));
- res = ecore_file_exists(dest_name);
- fail_if(res != EINA_TRUE);
- res = ecore_file_unlink(dest_name);
- fail_if(res != EINA_TRUE);
res = ecore_file_download("xxyyzz", dest_name, completion_cb,
progress_cb, NULL, &job);
@@ -525,8 +515,9 @@ EFL_START_TEST(ecore_test_ecore_file_download)
eina_hash_add(headers, "Content-type", "text/html");
res = ecore_file_download_full(download_url, dest_name, completion_cb,
- progress_cb, NULL, NULL, headers);
+ progress_cb, NULL, &job, headers);
fail_if(res != EINA_TRUE);
+ fail_if(!job);
ecore_main_loop_begin();
fprintf(stderr, "Downloaded %lld bytes\n", ecore_file_size(dest_name));
res = ecore_file_exists(dest_name);
--
