raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=eab91edcb233295862097cab93f6d76c795f1cdc

commit eab91edcb233295862097cab93f6d76c795f1cdc
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date:   Fri Apr 13 20:39:07 2018 +0900

    efl selection manager - fix dnd end handling to only handle on dnd
    
    dnd end handling was being done even if no dnd started, like an
    ungrab. this caused side effects like stoping selections in their
    tracks.
    
    @fix
---
 src/lib/elementary/efl_selection_manager.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/lib/elementary/efl_selection_manager.c 
b/src/lib/elementary/efl_selection_manager.c
index 0a003ba4d4..8c15f4dfe0 100644
--- a/src/lib/elementary/efl_selection_manager.c
+++ b/src/lib/elementary/efl_selection_manager.c
@@ -2707,6 +2707,9 @@ _wl_dnd_end(void *data, int type EINA_UNUSED, void *event)
    if (ev->serial != sel->drag_serial)
     return ECORE_CALLBACK_RENEW;
 
+   if (seat_sel->active_type != EFL_SELECTION_TYPE_DND)
+     return ECORE_CALLBACK_RENEW;
+
    efl_event_callback_call(seat_sel->drag_obj, EFL_UI_DND_EVENT_DRAG_DONE, 
NULL);
    if (seat_sel->drag_win)
      {

-- 


Reply via email to