sanghyeonlee pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e

commit c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e
Author: YeongJong Lee <yj34....@samsung.com>
Date:   Tue Apr 17 11:08:25 2018 +0900

    elm_dbus_menu: add missing const for Eina_List
    
    Summary:
    This fixes following warning
    
    ../src/lib/eina/eina_list.h:1421:10: warning: assignment discards ‘const’ 
qualifier from pointer target type [-Wdiscarded-qualifiers]
    
    Test Plan: make
    
    Reviewers: SanghyeonLee
    
    Reviewed By: SanghyeonLee
    
    Subscribers: cedric
    
    Differential Revision: https://phab.enlightenment.org/D5952
---
 src/lib/elementary/elm_dbus_menu.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/lib/elementary/elm_dbus_menu.c 
b/src/lib/elementary/elm_dbus_menu.c
index 0bf096347d..73b8a7bf0b 100644
--- a/src/lib/elementary/elm_dbus_menu.c
+++ b/src/lib/elementary/elm_dbus_menu.c
@@ -333,8 +333,7 @@ _root_layout_build(Elm_DBus_Menu *dbus_menu, Eina_List 
*property_list,
 {
    char *property;
    Eldbus_Message_Iter *layout, *array, *pair, *variant;
-   Eina_List *l;
-   const Eina_List *it;
+   const Eina_List *l, *it;
    Elm_Object_Item *obj_item;
 
    layout = eldbus_message_iter_container_new(iter, 'r', NULL);
@@ -422,8 +421,7 @@ _elm_dbus_menu_add(Eo *menu)
 {
    Elm_DBus_Menu *dbus_menu;
    Elm_Object_Item *obj_item;
-   const Eina_List *it;
-   Eina_List *l;
+   const Eina_List *it, *l;
 
    ELM_MENU_CHECK(menu) NULL;
 
@@ -457,7 +455,6 @@ _elm_dbus_menu_add(Eo *menu)
    return dbus_menu;
 
 error_hash:
-   eina_iterator_free(it);
    eina_hash_free(dbus_menu->elements);
 error_menu:
    free(dbus_menu);

-- 


Reply via email to