discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=39d8a36b5e3541f0c2b715c0df2784388487691d
commit 39d8a36b5e3541f0c2b715c0df2784388487691d Author: Marcel Hollerbach <[email protected]> Date: Tue Jun 19 13:35:38 2018 -0400 eo: only call efl_parent_set when parent_id is available Summary: this is no functinal change, we safe the calling to efl_parent_set. Nothing else, the base implementation is initializated with NULL as parent, and efl_parent_set with NULL would have returned in the first few lines. fix T7032 Reviewers: devilhorns, zmike Reviewed By: zmike Subscribers: cedric, #committers, zmike Tags: #efl Maniphest Tasks: T7032 Differential Revision: https://phab.enlightenment.org/D6327 --- src/lib/eo/eo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 2df52d36df..6dbd66be64 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -911,7 +911,7 @@ _efl_add_internal_start(const char *file, int line, const Efl_Class *klass_id, E efl_ref(eo_id); /* Reference for the parent if is_ref is done in _efl_add_end */ - efl_parent_set(eo_id, parent_id); + if (parent_id) efl_parent_set(eo_id, parent_id); /* eo_id can change here. Freeing is done on the resolved object. */ eo_id = efl_constructor(eo_id); --
