discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=4378d6feb9b62b11870d76c918fcbb7a95197fee
commit 4378d6feb9b62b11870d76c918fcbb7a95197fee Author: Marcel Hollerbach <[email protected]> Date: Mon Jun 25 06:50:31 2018 -0400 eo: lower from CRI to ERR Summary: unreffing too often is not good. However, its definitly not a critical error. Most of the wikipedia articles (*) that are speaking about ciritcal or fatal errors are highlighting that no reasonable recovery can be done. In our case a recovery is not even needed, due to our pointer safety we dont need to recover anything since the refcounting safed us from doing something stupid. ref T6987. Depends on D6384 Reviewers: zmike, segfaultxavi, devilhorns Reviewed By: zmike Subscribers: cedric, #committers Tags: #efl Maniphest Tasks: T6987 Differential Revision: https://phab.enlightenment.org/D6385 --- src/lib/eo/eo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 63cb2a2db0..f2ee051c7e 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -1923,7 +1923,7 @@ efl_unref(const Eo *obj_id) { if (obj->user_refcount < 0) { - CRI("Obj:%s@%p. User refcount (%d) < 0. Too many unrefs.", + ERR("Obj:%s@%p. User refcount (%d) < 0. Too many unrefs.", obj->klass->desc->name, obj_id, obj->user_refcount); _eo_log_obj_report((Eo_Id)obj_id, EINA_LOG_LEVEL_ERR, __FUNCTION__, __FILE__, __LINE__); EO_OBJ_DONE(obj_id); --
