kwo pushed a commit to branch master.

http://git.enlightenment.org/legacy/imlib2.git/commit/?id=cbc09c03454f627e3530dac759b2c9fecf85931f

commit cbc09c03454f627e3530dac759b2c9fecf85931f
Author: Kim Woelders <k...@woelders.dk>
Date:   Fri Jul 20 05:46:51 2018 +0200

    XPM loader: Fix potentially uninitialized pixel data
    
    Pixels with color "none" were composed using uninitialised GB values.
    
    Although the pixels were "correct", as RGB are don't-care when A is 0,
    let's not put random data in images and avoid valgrind complaints.
    
    Thanks to Sebastien Ballet for test case.
---
 src/modules/loaders/loader_xpm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/modules/loaders/loader_xpm.c b/src/modules/loaders/loader_xpm.c
index 8e24c7d..a4a486d 100644
--- a/src/modules/loaders/loader_xpm.c
+++ b/src/modules/loaders/loader_xpm.c
@@ -278,6 +278,9 @@ load(ImlibImage * im, ImlibProgressFunction progress, char 
progress_granularity,
                                              {
                                                 transp = 1;
                                                 cmap[j].transp = 1;
+                                                cmap[j].r = 0;
+                                                cmap[j].g = 0;
+                                                cmap[j].b = 0;
                                              }
                                            else
                                              {

-- 


Reply via email to