discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1bdda117a19f03d3ba86e6ee86b7a273a49aab56
commit 1bdda117a19f03d3ba86e6ee86b7a273a49aab56 Author: Alastair Poole <[email protected]> Date: Thu Aug 16 10:12:35 2018 -0400 elm_code_line: fix potential crash. Summary: This can occur and thus malloc will return NULL when line->length is 0. Check for !line->length and return. Very difficult to reproduce, but I had managed three times, and avoided a crash. Reviewers: #committers, ajwillia.ms, zmike Reviewed By: #committers, zmike Subscribers: cedric, #reviewers, zmike Tags: #efl Differential Revision: https://phab.enlightenment.org/D6842 --- src/lib/elementary/elm_code_text.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_code_text.c b/src/lib/elementary/elm_code_text.c index 1ebdb0999e..641dc41604 100644 --- a/src/lib/elementary/elm_code_text.c +++ b/src/lib/elementary/elm_code_text.c @@ -189,7 +189,7 @@ elm_code_line_text_remove(Elm_Code_Line *line, unsigned int position, int length Elm_Code_File *file; char *removed; - if (!line) + if (!line || !line->length) return; removed = malloc(sizeof(char) * line->length - length); --
