jaehyun pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=ecc6fe749ca094274a751577add91388ec2ff52d
commit ecc6fe749ca094274a751577add91388ec2ff52d Author: JunsuChoi <[email protected]> Date: Mon Oct 8 11:19:53 2018 +0900 ecore_con_legacy: fix coverity issues (use after free) Summary: for hard failures (highly unlikely), the handle would be deleted and the next use would crash. Test Plan: N/A Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n Reviewed By: bu5hm4n Subscribers: bu5hm4n, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D7139 --- src/lib/ecore_con/ecore_con_legacy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/ecore_con/ecore_con_legacy.c b/src/lib/ecore_con/ecore_con_legacy.c index bd199a8278..94ff9bbd6e 100644 --- a/src/lib/ecore_con/ecore_con_legacy.c +++ b/src/lib/ecore_con/ecore_con_legacy.c @@ -1346,8 +1346,8 @@ _ecore_con_server_dialer_error(void *data, const Efl_Event *event) WRN("error reaching server %s: %s", efl_net_dialer_address_dial_get(svr->dialer), eina_error_msg_get(*perr)); - _ecore_con_post_event_server_error(svr, eina_error_msg_get(*perr)); - _ecore_con_server_dialer_close(svr); + if (_ecore_con_post_event_server_error(svr, eina_error_msg_get(*perr))) + _ecore_con_server_dialer_close(svr); } static void --
