derekf pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=1139cde9a6917fb3f5285f777398272ad0cb6503
commit 1139cde9a6917fb3f5285f777398272ad0cb6503 Author: Derek Foreman <[email protected]> Date: Wed Dec 5 10:12:01 2018 -0600 ecore_evas: Validate shadow geometry Negative values in shadow geometry make no sense at all, however it's happening all the time in wayland. Let's throw an ERR so it doesn't go unnoticed. Signed-off-by: Derek Foreman <[email protected]> Reviewed-by: Chris Michael <[email protected]> Differential Revision: https://phab.enlightenment.org/D7434 --- src/lib/ecore_evas/ecore_evas.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/lib/ecore_evas/ecore_evas.c b/src/lib/ecore_evas/ecore_evas.c index 109b5ef79a..14c3792036 100644 --- a/src/lib/ecore_evas/ecore_evas.c +++ b/src/lib/ecore_evas/ecore_evas.c @@ -2793,6 +2793,10 @@ EAPI void ecore_evas_shadow_geometry_set(Ecore_Evas *ee, int l, int r, int t, int b) { ECORE_EVAS_CHECK(ee); + EINA_SAFETY_ON_TRUE_RETURN(l < 0); + EINA_SAFETY_ON_TRUE_RETURN(r < 0); + EINA_SAFETY_ON_TRUE_RETURN(t < 0); + EINA_SAFETY_ON_TRUE_RETURN(b < 0); if ((ee->shadow.l == l) && (ee->shadow.r == r) && (ee->shadow.t == t) && (ee->shadow.b == b)) return; ee->shadow.l = l; --
