raster pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=01575d590e9ae0dfc48397aac44e1fe737f93b6f
commit 01575d590e9ae0dfc48397aac44e1fe737f93b6f Author: Carsten Haitzler (Rasterman) <[email protected]> Date: Fri Jan 11 16:29:54 2019 +0000 e mime cfg - skip work when string is empty - fixes warning --- src/modules/fileman/e_int_config_mime.c | 31 +++++++++++++++++-------------- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/src/modules/fileman/e_int_config_mime.c b/src/modules/fileman/e_int_config_mime.c index 0fb268b78..64bb3f0ae 100644 --- a/src/modules/fileman/e_int_config_mime.c +++ b/src/modules/fileman/e_int_config_mime.c @@ -322,23 +322,26 @@ _load_mimes(E_Config_Dialog_Data *cfdata, char *file) pp = p; while (!isblank(*p) && (*p != 0) && (*p != '\n')) p++; - strncpy(ext, pp, (p - pp)); - ext[p - pp] = 0; - config_mime = _find_mime(cfdata, mimetype); - if (!config_mime) + if (p > pp) { - config_mime = E_NEW(Config_Mime, 1); - if (config_mime) + strncpy(ext, pp, (p - pp)); + ext[p - pp] = 0; + config_mime = _find_mime(cfdata, mimetype); + if (!config_mime) { - config_mime->mime = eina_stringshare_add(mimetype); - if (!config_mime->mime) - free(config_mime); - else + config_mime = E_NEW(Config_Mime, 1); + if (config_mime) { - config_glob = E_NEW(Config_Glob, 1); - config_glob->name = eina_stringshare_add(ext); - config_mime->globs = eina_list_append(config_mime->globs, config_glob); - cfdata->mimes = eina_list_append(cfdata->mimes, config_mime); + config_mime->mime = eina_stringshare_add(mimetype); + if (!config_mime->mime) + free(config_mime); + else + { + config_glob = E_NEW(Config_Glob, 1); + config_glob->name = eina_stringshare_add(ext); + config_mime->globs = eina_list_append(config_mime->globs, config_glob); + cfdata->mimes = eina_list_append(cfdata->mimes, config_mime); + } } } } --
