zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=f76d04683b4dabd45f2446ca5e567683941ea27b
commit f76d04683b4dabd45f2446ca5e567683941ea27b
Author: Marcel Hollerbach <m...@marcel-hollerbach.de>
Date: Thu Feb 28 08:48:37 2019 -0500
elm_popup: remove on_show_region_set call
Summary:
Its hard to say why removing such calls are fixing a bug like T7274.
However, it appears that this call causes the min size calculation of
evas to fall apart. This also removes a workarround introduced earlier
to fix this.
This fixes T7274
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7274
Differential Revision: https://phab.enlightenment.org/D8043
---
src/lib/elementary/elc_popup.c | 8 --------
src/lib/elementary/elm_scroller.c | 5 -----
2 files changed, 13 deletions(-)
diff --git a/src/lib/elementary/elc_popup.c b/src/lib/elementary/elc_popup.c
index 8c4684e0b3..4806d5f152 100644
--- a/src/lib/elementary/elc_popup.c
+++ b/src/lib/elementary/elc_popup.c
@@ -503,14 +503,6 @@ _elm_popup_elm_layout_sizing_eval(Eo *obj, Elm_Popup_Data
*sd)
else
evas_object_size_hint_min_set(sd->spacer, minw, minh);
- if (sd->main_layout)
- {
- Evas *ev = evas_object_evas_get(sd->main_layout);
- if (evas_smart_objects_calculating_get(ev))
- evas_object_smart_calculate(sd->main_layout);
- else
- evas_object_smart_need_recalculate_set(sd->main_layout,
EINA_TRUE);
- }
return;
}
diff --git a/src/lib/elementary/elm_scroller.c
b/src/lib/elementary/elm_scroller.c
index 0409cd9d31..134dd1c1d7 100644
--- a/src/lib/elementary/elm_scroller.c
+++ b/src/lib/elementary/elm_scroller.c
@@ -886,11 +886,6 @@ _focused_element(void *data, const Efl_Event *event)
geom.y = geom.y + pan_y - pos.y;
elm_interface_scrollable_region_bring_in(obj, geom.x, geom.y, geom.w,
geom.h);
-
- geom = efl_gfx_entity_geometry_get(obj);
- geom.x = geom.y = 0;
- elm_widget_show_region_set(obj, geom, EINA_TRUE);
-
}
EOLIAN static Eo *
--
