xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7dc546bdedeb82db8d3e2524d28fb0f962005351
commit 7dc546bdedeb82db8d3e2524d28fb0f962005351
Author: Mike Blumenkrantz <zm...@samsung.com>
Date: Thu Mar 14 20:14:19 2019 +0100
ci: add missing double quote for osx autotools
Summary:
so there I was, out at the pub after a hard release cycle, drinking
GNU's finest, and a " comes over and challenges me to a duel--
editors at 50pt. the " cheats and gets me right in the repo before
the countdown ends and then I'm out cold.
I wake up the next day with CI (still) failing, hundreds of pings on IRC
asking where I've been, and my refrigerator is somehow filled with ethernet
cables (cat7) which I have no memory of purchasing. my computer has doodles
in permanent marker all over the screen, and my cat is somehow stuck in a
ceiling vent which I also have no memory of seeing. also this isn't my
house.
I leave the building, which turns out to be a fast food franchise a few
blocks
away from my gym, and the cops roll up (https://i.imgur.com/JnOI4Jz.gifv)
asking to see some identification. I show them my credentials (ssh RSA4096),
and they cuff me. I'm under arrest for failing to close a double quote and
submitting a patch which impersonated a fix to a failing CI job.
the moral of this story is to always reread your patches and make sure
you've
matched up all your punctuation.
ref D8340
Reviewers: devilhorns, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D8356
---
.ci/ci-configure.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/ci-configure.sh b/.ci/ci-configure.sh
index c4b295e919..464380c0e0 100755
--- a/.ci/ci-configure.sh
+++ b/.ci/ci-configure.sh
@@ -148,7 +148,7 @@ else
export CFLAGS="-I/usr/local/opt/openssl/include -frewrite-includes $CFLAGS"
export LDFLAGS="-L/usr/local/opt/openssl/lib $LDFLAGS"
LIBFFI_VER=$(brew list --versions libffi|head -n1|cut -d' ' -f2)
- export
PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig:/usr/local/Cellar/libffi/$LIBFFI_VER/lib/pkgconfig
+ export
PKG_CONFIG_PATH="/usr/local/opt/openssl/lib/pkgconfig:/usr/local/Cellar/libffi/$LIBFFI_VER/lib/pkgconfig"
# Normal build test of all targets
rm -f ~/.ccache/ccache.conf
--
