zmike pushed a commit to branch efl-1.22. http://git.enlightenment.org/core/efl.git/commit/?id=d70f175cda8bef6c8ddc1a2076f3257f6edfa0d9
commit d70f175cda8bef6c8ddc1a2076f3257f6edfa0d9 Author: Marcel Hollerbach <[email protected]> Date: Sun Mar 31 18:12:48 2019 +0200 efl_ui_widget: we should ensure that every subobject is a gfx entity we are calling visible_set on them later on, this will drop errors, additionally this safes us from checking this in the widget-container code. Reviewed-by: Xavi Artigas <[email protected]> Reviewed-by: Cedric BAIL <[email protected]> Differential Revision: https://phab.enlightenment.org/D8520 --- src/lib/elementary/efl_ui_widget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/elementary/efl_ui_widget.c b/src/lib/elementary/efl_ui_widget.c index 99da93aa3b..6ab2d8a026 100644 --- a/src/lib/elementary/efl_ui_widget.c +++ b/src/lib/elementary/efl_ui_widget.c @@ -1486,6 +1486,7 @@ _efl_ui_widget_widget_sub_object_add(Eo *obj, Elm_Widget_Smart_Data *sd, Evas_Ob Efl_Ui_Widget *parent; if (!sobj) return EINA_FALSE; + EINA_SAFETY_ON_FALSE_RETURN_VAL(efl_isa(sobj, EFL_GFX_ENTITY_INTERFACE), EINA_FALSE); EINA_SAFETY_ON_TRUE_RETURN_VAL(obj == sobj, EINA_FALSE); //first make sure that we unregister the sobj from the parent --
