bu5hm4n pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=14a65b4f67d72f6d69139eeafea811f0b7e80599
commit 14a65b4f67d72f6d69139eeafea811f0b7e80599 Author: Marcel Hollerbach <[email protected]> Date: Fri Apr 26 14:29:20 2019 +0200 efl_ui_pager: lets stop returning false when in animation i don't know why this is here. But undependend from if the widget is in animation or not. We should ensure that the added content to the pager is displayed and added. Having this failing is super unexpected to the user, and basically undebuggable. Reviewed-by: Cedric BAIL <[email protected]> Differential Revision: https://phab.enlightenment.org/D8738 --- src/lib/elementary/efl_ui_pager.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/lib/elementary/efl_ui_pager.c b/src/lib/elementary/efl_ui_pager.c index 1566da560e..580887cdef 100644 --- a/src/lib/elementary/efl_ui_pager.c +++ b/src/lib/elementary/efl_ui_pager.c @@ -403,8 +403,6 @@ _efl_ui_pager_efl_pack_linear_pack_begin(Eo *obj EINA_UNUSED, Efl_Ui_Pager_Data *pd, Efl_Gfx_Entity *subobj) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - pd->content_list = eina_list_prepend(pd->content_list, subobj); pd->cnt++; @@ -430,8 +428,6 @@ _efl_ui_pager_efl_pack_linear_pack_end(Eo *obj EINA_UNUSED, Efl_Ui_Pager_Data *pd, Efl_Gfx_Entity *subobj) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - pd->content_list = eina_list_append(pd->content_list, subobj); pd->cnt++; @@ -458,8 +454,6 @@ _efl_ui_pager_efl_pack_linear_pack_before(Eo *obj EINA_UNUSED, Efl_Gfx_Entity *subobj, const Efl_Gfx_Entity *existing) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - int index = eina_list_data_idx(pd->content_list, (void *)existing); if (index == -1) return EINA_FALSE; @@ -484,8 +478,6 @@ _efl_ui_pager_efl_pack_linear_pack_after(Eo *obj EINA_UNUSED, Efl_Gfx_Entity *subobj, const Efl_Gfx_Entity *existing) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - int index = eina_list_data_idx(pd->content_list, (void *)existing); if (index == -1) return EINA_FALSE; @@ -510,8 +502,6 @@ _efl_ui_pager_efl_pack_linear_pack_at(Eo *obj, Efl_Gfx_Entity *subobj, int index) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - if ((index > pd->cnt) || (index < 0)) { return EINA_FALSE; @@ -892,8 +882,6 @@ _efl_ui_pager_efl_pack_unpack(Eo *obj, Efl_Ui_Pager_Data *pd, Efl_Gfx_Entity *subobj) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return EINA_FALSE; - if (!subobj) return EINA_FALSE; int index = eina_list_data_idx(pd->content_list, subobj); @@ -909,8 +897,6 @@ _efl_ui_pager_efl_pack_linear_pack_unpack_at(Eo *obj, Efl_Ui_Pager_Data *pd, int index) { - if (!EINA_DBL_EQ(pd->curr.pos, 0.0)) return NULL; - if ((index >= pd->cnt) || (index < 0)) return NULL; Efl_Gfx_Entity *subobj = eina_list_nth(pd->content_list, index); --
