bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=c52dcdac915b9821c5744c34fe501176d8df3bc1

commit c52dcdac915b9821c5744c34fe501176d8df3bc1
Author: Marcel Hollerbach <[email protected]>
Date:   Fri Apr 26 17:19:37 2019 +0200

    efl_ui_pager: ensure objects are added and deduplicated
    
    everything else will make things fall apart
    
    Reviewed-by: Cedric BAIL <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D8741
---
 src/lib/elementary/efl_ui_pager.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/lib/elementary/efl_ui_pager.c 
b/src/lib/elementary/efl_ui_pager.c
index e5856a88ba..b97737ab51 100644
--- a/src/lib/elementary/efl_ui_pager.c
+++ b/src/lib/elementary/efl_ui_pager.c
@@ -401,6 +401,14 @@ _efl_ui_pager_efl_container_content_count(Eo *obj 
EINA_UNUSED,
 static Eina_Bool
 _register_child(Eo *obj EINA_UNUSED, Efl_Ui_Pager_Data *pd, Efl_Gfx_Entity 
*subobj)
 {
+   if (eina_list_data_find(pd->content_list, subobj))
+     {
+        ERR("Object already added!");
+        return EINA_FALSE;
+     }
+   if (!efl_ui_widget_sub_object_add(obj, subobj))
+     return EINA_FALSE;
+
    if (!pd->transition)
      efl_canvas_object_clipper_set(subobj, pd->backclip);
 

-- 


Reply via email to