zmike pushed a commit to branch efl-1.22. http://git.enlightenment.org/core/efl.git/commit/?id=50547a9cb166fd7114d153b4986d6a2a3e3fdc22
commit 50547a9cb166fd7114d153b4986d6a2a3e3fdc22 Author: Christopher Michael <[email protected]> Date: Sat Apr 27 14:21:43 2019 -0400 elc_hoversel: Fix crash when no sd->last_location As we cannot pass NULL to strcmp (crashes when we do), we should check for a valid sd->last_location here in order to avoid crashing. This was detected in Enlightenment Screen Settings dialog by selecting a monitor in the hoversel drop down. @fix --- src/lib/elementary/elc_hoversel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/elc_hoversel.c b/src/lib/elementary/elc_hoversel.c index 56b7113b62..bf5cb4ab8e 100644 --- a/src/lib/elementary/elc_hoversel.c +++ b/src/lib/elementary/elc_hoversel.c @@ -296,7 +296,7 @@ _sizing_eval(void *data) if (sd->horizontal) { - if (!strcmp(sd->last_location, "left")) + if ((sd->last_location) && (!strcmp(sd->last_location, "left"))) { adjusted.x = parent.x; if ((adjusted.x + adjusted.w) > base.x) @@ -314,7 +314,7 @@ _sizing_eval(void *data) } else { - if (!strcmp(sd->last_location, "top")) + if ((sd->last_location) && (!strcmp(sd->last_location, "top"))) { adjusted.y = parent.y; if ((adjusted.y + adjusted.h) > base.y) --
