zmike pushed a commit to branch efl-1.22.

http://git.enlightenment.org/core/efl.git/commit/?id=5e9b279dc145bfbff062ed7475ca17cca6b967da

commit 5e9b279dc145bfbff062ed7475ca17cca6b967da
Author: Christopher Michael <[email protected]>
Date:   Tue Apr 23 09:13:19 2019 -0400

    elm_atspi_bridget: Fix resource leak
    
    Coverity reports and 'req' leaks here so we need to unref the eldbus
    message object if we are exiting this function.
    
    Fixes CID1399424
    
    @fix
---
 src/lib/elementary/elm_atspi_bridge.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/elm_atspi_bridge.c 
b/src/lib/elementary/elm_atspi_bridge.c
index c689557d6c..9341b64981 100644
--- a/src/lib/elementary/elm_atspi_bridge.c
+++ b/src/lib/elementary/elm_atspi_bridge.c
@@ -4688,7 +4688,11 @@ _elm_atspi_bridge_key_filter(void *data, void *loop 
EINA_UNUSED, int type, void
      }
 
    ke = _key_event_info_new(type, key_event, bridge);
-   if (!ke) return EINA_TRUE;
+   if (!ke)
+     {
+        eldbus_message_unref(req);
+        return EINA_TRUE;
+     }
 
    iter = eldbus_message_iter_get(req);
    _iter_marshall_key_event(iter, ke);

-- 


Reply via email to