zmike pushed a commit to branch efl-1.22.

http://git.enlightenment.org/core/efl.git/commit/?id=633b14277bd12cdbb0c5b23a41a43ae42e084646

commit 633b14277bd12cdbb0c5b23a41a43ae42e084646
Author: Marcel Hollerbach <[email protected]>
Date:   Wed Apr 24 19:16:57 2019 +0200

    efl_ui_grid: do not delete a item that is not part of this container
    
    otherwise we start to delete callbacks etc. on a widget that we do not
    have.
    
    Reviewed-by: SangHyeon Jade Lee <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D8706
---
 src/lib/elementary/efl_ui_grid.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/lib/elementary/efl_ui_grid.c b/src/lib/elementary/efl_ui_grid.c
index 1eddf95db2..306404ac3d 100644
--- a/src/lib/elementary/efl_ui_grid.c
+++ b/src/lib/elementary/efl_ui_grid.c
@@ -1063,6 +1063,12 @@ _efl_ui_grid_efl_pack_unpack(Eo *obj, Efl_Ui_Grid_Data 
*pd, Efl_Gfx_Entity *subo
 {
    Efl_Ui_Grid_Item *item = (Efl_Ui_Grid_Item *)subobj;
 
+   if (!eina_list_data_find(pd->items, item))
+     {
+        ERR("Element is not part of this container");
+        return EINA_FALSE;
+     }
+
    _grid_item_unpack_internal(obj, pd, item);
 
    elm_layout_sizing_eval(obj);

-- 


Reply via email to