xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b563fed2e48fe44786f02b39939a39501b7c2e6e

commit b563fed2e48fe44786f02b39939a39501b7c2e6e
Author: Christopher Michael <[email protected]>
Date:   Thu May 2 13:47:22 2019 +0200

    evas_test_image: Fix resource leak
    
    Summary:
    Coverity reports that we leak variable 'f' going out of scope here, so
    if we are going to exit the test, lets close the file before we do
    
    Fixes CID1400945
    
    @fix
    Depends on D8770
    
    Reviewers: raster, cedric, zmike, bu5hm4n, segfaultxavi
    
    Reviewed By: segfaultxavi
    
    Subscribers: segfaultxavi, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D8771
---
 src/tests/evas/evas_test_image.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/tests/evas/evas_test_image.c b/src/tests/evas/evas_test_image.c
index 259cff77d3..19ae8ffb6a 100644
--- a/src/tests/evas/evas_test_image.c
+++ b/src/tests/evas/evas_test_image.c
@@ -647,6 +647,7 @@ _file_to_memory(const char *filename, char **result)
    if ((size_t)size != fread(*result, sizeof(char), size, f))
      {
         free(*result);
+        fclose(f);
         return -1;
      }
    fclose(f);

-- 


Reply via email to