bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=4398ec7b3bdec90abbef5765d1b0521ae35ef2f7

commit 4398ec7b3bdec90abbef5765d1b0521ae35ef2f7
Author: Lauro Moura <[email protected]>
Date:   Fri Dec 6 14:57:52 2019 +0000

    elementary: Fix declaration of CV managers getters
    
    This should convey better their intention of the setting taking
    ownership of the passed value and the getter returning just a view to
    them.
    
    Fixes T8514
    
    Reviewed-by: Marcel Hollerbach <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D10824
---
 src/lib/elementary/efl_ui_collection.eo          |  6 ++++++
 src/lib/elementary/efl_ui_collection_view.eo     |  6 ++++++
 src/lib/elementary/efl_ui_spotlight_container.eo | 12 ++++++++++++
 3 files changed, 24 insertions(+)

diff --git a/src/lib/elementary/efl_ui_collection.eo 
b/src/lib/elementary/efl_ui_collection.eo
index 342feea116..4a5a440002 100644
--- a/src/lib/elementary/efl_ui_collection.eo
+++ b/src/lib/elementary/efl_ui_collection.eo
@@ -53,6 +53,12 @@ class Efl.Ui.Collection extends Efl.Ui.Layout_Base implements
       }
       @property position_manager @beta {
          [[Position manager object that handles placement of items.]]
+         get {
+            values {
+               position_manager : Efl.Ui.Position_Manager.Entity; [[A borrowed 
handle to the item container.]]
+            }
+         }
+         set { }
          values {
             position_manager : Efl.Ui.Position_Manager.Entity @move; 
[[Ownership is passed to the item container.]]
          }
diff --git a/src/lib/elementary/efl_ui_collection_view.eo 
b/src/lib/elementary/efl_ui_collection_view.eo
index 65a1ee9e62..669554db29 100644
--- a/src/lib/elementary/efl_ui_collection_view.eo
+++ b/src/lib/elementary/efl_ui_collection_view.eo
@@ -37,6 +37,12 @@ class Efl.Ui.Collection_View extends Efl.Ui.Layout_Base 
implements
       }
       @property position_manager @beta {
         [[Position manager object that handles placement of items.]]
+        get {
+           values {
+              position_manager : Efl.Ui.Position_Manager.Entity; [[ A borrowed 
reference to the manager. ]]
+           }
+        }
+        set { }
         values {
            position_manager : Efl.Ui.Position_Manager.Entity @move; [[The 
objects ownership is passed to the item container.]]
         }
diff --git a/src/lib/elementary/efl_ui_spotlight_container.eo 
b/src/lib/elementary/efl_ui_spotlight_container.eo
index 860d1beb71..857f2655e1 100644
--- a/src/lib/elementary/efl_ui_spotlight_container.eo
+++ b/src/lib/elementary/efl_ui_spotlight_container.eo
@@ -32,6 +32,12 @@ class @beta Efl.Ui.Spotlight.Container extends Efl.Ui.Widget 
implements Efl.Pack
         [[This object defines how sub-widgets are rendered and animated.
           If it is not set, only the active sub-widget is shown and 
transitions are instantaneous (not animated).
         ]]
+        get {
+           values {
+              spotlight_manager : Efl.Ui.Spotlight.Manager; [[The Spotlight 
Manager object or $NULL.]]
+           }
+        }
+        set { }
         values {
           spotlight_manager : Efl.Ui.Spotlight.Manager @move; [[The Spotlight 
Manager object or $NULL.]]
         }
@@ -42,6 +48,12 @@ class @beta Efl.Ui.Spotlight.Container extends Efl.Ui.Widget 
implements Efl.Pack
           When this object is set, it is immediately updated to reflect the 
current state of the widget.
           Its location inside the container is controlled by the 
@.spotlight_manager.
         ]]
+        get {
+           values {
+              indicator : Efl.Ui.Spotlight.Indicator; [[The Indicator object 
or $NULL.]]
+           }
+        }
+        set { }
         values {
           indicator : Efl.Ui.Spotlight.Indicator @move; [[The Indicator object 
or $NULL.]]
         }

-- 


Reply via email to