zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=9144e4dae7a84d53ff6d69e43ef34ad13ba298d3
commit 9144e4dae7a84d53ff6d69e43ef34ad13ba298d3 Author: Stefan Schmidt <[email protected]> Date: Tue Dec 24 09:23:22 2019 -0500 examples: js: make sure we declare all variables Summary: Avoiding local variables to be declared global and shared automatically. Depends on D10882 Reported-By: https://lgtm.com/projects/g/Enlightenment/efl Reviewers: felipealmeida, zmike Reviewed By: zmike Subscribers: zmike, ProhtMeyhet, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10884 --- src/examples/elementary/button_example_01.js | 2 +- src/examples/elementary/slider_example.js | 4 ++-- src/examples/elementary/twitter_example_01.js | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/examples/elementary/button_example_01.js b/src/examples/elementary/button_example_01.js index 2f540220d0..89a48867f3 100644 --- a/src/examples/elementary/button_example_01.js +++ b/src/examples/elementary/button_example_01.js @@ -1,7 +1,7 @@ efl = require('efl'); function setIcon(widget, icon) { - container = widget.part("icon").cast("Efl.Content"); + var container = widget.part("icon").cast("Efl.Content"); container.setContent(icon); } diff --git a/src/examples/elementary/slider_example.js b/src/examples/elementary/slider_example.js index ec59ee1c81..f3125e5e01 100644 --- a/src/examples/elementary/slider_example.js +++ b/src/examples/elementary/slider_example.js @@ -91,13 +91,13 @@ sl.setVisible(true); sl.on('changed', function(obj) { - val = obj.getProgressValue(); + var val = obj.getProgressValue(); console.log("Changed to " + val); }); sl.on('delay_changed', function(obj) { - val = obj.getProgressValue(); + var val = obj.getProgressValue(); console.log("Delay changed to " + val); }); diff --git a/src/examples/elementary/twitter_example_01.js b/src/examples/elementary/twitter_example_01.js index ba00b05900..b6c40915be 100644 --- a/src/examples/elementary/twitter_example_01.js +++ b/src/examples/elementary/twitter_example_01.js @@ -43,7 +43,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio if (error) return; - for(i=0; i < tweets.length; i++){ + for(var i=0; i < tweets.length; i++){ var user_name = tweets[i].user.name; var screen_name = tweets[i].user.screen_name; var text = tweets[i].text; @@ -58,7 +58,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio var entry = new efl.Elm.Entry(win); entry.setPartText("elm.text", text); entry.setEditable(false); - part = layout.part("tweet_text").cast("Efl.Content"); + var part = layout.part("tweet_text").cast("Efl.Content"); part.setContent(entry); layout.setHintMin(127, 96); @@ -68,7 +68,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio var icon = new efl.Efl.Ui.Image(win); icon.fillInside = true; icon_array.push(icon); - user_icon = layout.part("user_icon").cast("Efl.Content"); + var user_icon = layout.part("user_icon").cast("Efl.Content"); user_icon.setContent(icon); item = tweet_box.packEnd(layout); layout.setVisible(true); @@ -78,7 +78,7 @@ twit.get('statuses/user_timeline', {screen_name: user_acount, count:10}, functio var file = fs.createWriteStream(icon_filename); file.on('finish', function() { console.log("finished loading the icon file."); - for (i=0; i < icon_array.length; i++) { + for (var i=0; i < icon_array.length; i++) { icon_array[i].setFile(icon_filename, null); } }); --
