zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=cdb21cd30d26a39cd33362698b1098ee1b3f957b
commit cdb21cd30d26a39cd33362698b1098ee1b3f957b Author: Marcel Hollerbach <[email protected]> Date: Mon Dec 30 11:08:53 2019 -0500 efl_ui_progressbar: rename from pulse to infinite_mode Summary: ref T8501 Depends on D10942 Reviewers: cedric, woohyun, zmike, segfaultxavi Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T8501 Differential Revision: https://phab.enlightenment.org/D10943 --- src/bin/elementary/test_part_shadow.c | 20 ++++++++++---------- src/bin/elementary/test_ui_progressbar.c | 2 +- src/lib/elementary/efl_ui_progressbar.c | 4 ++-- src/lib/elementary/efl_ui_progressbar.eo | 7 ++++--- 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/bin/elementary/test_part_shadow.c b/src/bin/elementary/test_part_shadow.c index dd6f388bdb..12b202c86e 100644 --- a/src/bin/elementary/test_part_shadow.c +++ b/src/bin/elementary/test_part_shadow.c @@ -37,11 +37,11 @@ pulse_start(void *data, const Efl_Event *ev EINA_UNUSED) { Test_Data *td = data; - efl_ui_progressbar_pulse_set(td->pb1, EINA_TRUE); - efl_ui_progressbar_pulse_set(td->pb2, EINA_TRUE); - efl_ui_progressbar_pulse_set(td->pb3, EINA_TRUE); - efl_ui_progressbar_pulse_set(td->pb4, EINA_TRUE); - efl_ui_progressbar_pulse_set(td->pb5, EINA_TRUE); + efl_ui_progressbar_infinite_mode_set(td->pb1, EINA_TRUE); + efl_ui_progressbar_infinite_mode_set(td->pb2, EINA_TRUE); + efl_ui_progressbar_infinite_mode_set(td->pb3, EINA_TRUE); + efl_ui_progressbar_infinite_mode_set(td->pb4, EINA_TRUE); + efl_ui_progressbar_infinite_mode_set(td->pb5, EINA_TRUE); efl_ui_widget_disabled_set(td->btn_start, EINA_TRUE); efl_ui_widget_disabled_set(td->btn_stop, EINA_FALSE); @@ -54,11 +54,11 @@ pulse_stop(void *data, const Efl_Event *ev EINA_UNUSED) { Test_Data *td = data; - efl_ui_progressbar_pulse_set(td->pb1, EINA_FALSE); - efl_ui_progressbar_pulse_set(td->pb2, EINA_FALSE); - efl_ui_progressbar_pulse_set(td->pb3, EINA_FALSE); - efl_ui_progressbar_pulse_set(td->pb4, EINA_FALSE); - efl_ui_progressbar_pulse_set(td->pb5, EINA_FALSE); + efl_ui_progressbar_infinite_mode_set(td->pb1, EINA_FALSE); + efl_ui_progressbar_infinite_mode_set(td->pb2, EINA_FALSE); + efl_ui_progressbar_infinite_mode_set(td->pb3, EINA_FALSE); + efl_ui_progressbar_infinite_mode_set(td->pb4, EINA_FALSE); + efl_ui_progressbar_infinite_mode_set(td->pb5, EINA_FALSE); efl_ui_widget_disabled_set(td->btn_start, EINA_FALSE); efl_ui_widget_disabled_set(td->btn_stop, EINA_TRUE); diff --git a/src/bin/elementary/test_ui_progressbar.c b/src/bin/elementary/test_ui_progressbar.c index a9ca9a86f8..faea211629 100644 --- a/src/bin/elementary/test_ui_progressbar.c +++ b/src/bin/elementary/test_ui_progressbar.c @@ -179,7 +179,7 @@ test_ui_progressbar(void *data EINA_UNUSED, Eo *obj EINA_UNUSED, void *event_inf pd->pb2 = efl_add(EFL_UI_PROGRESSBAR_CLASS, bx, efl_pack(bx, efl_added), efl_text_set(efl_added, "10-100"), - efl_ui_progressbar_pulse_set(efl_added, EINA_TRUE), + efl_ui_progressbar_infinite_mode_set(efl_added, EINA_TRUE), efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(250, 20)), efl_ui_range_limits_set(efl_added, 10, 100), efl_ui_range_value_set(efl_added, 10) diff --git a/src/lib/elementary/efl_ui_progressbar.c b/src/lib/elementary/efl_ui_progressbar.c index 1ba11d05f7..9aec5fd808 100644 --- a/src/lib/elementary/efl_ui_progressbar.c +++ b/src/lib/elementary/efl_ui_progressbar.c @@ -628,7 +628,7 @@ _apply_pulse_state(Eo *obj, Efl_Ui_Progressbar_Data *sd) } EOLIAN static void -_efl_ui_progressbar_pulse_set(Eo *obj, Efl_Ui_Progressbar_Data *sd, Eina_Bool state) +_efl_ui_progressbar_infinite_mode_set(Eo *obj, Efl_Ui_Progressbar_Data *sd, Eina_Bool state) { state = !!state; @@ -642,7 +642,7 @@ _efl_ui_progressbar_pulse_set(Eo *obj, Efl_Ui_Progressbar_Data *sd, Eina_Bool st } EOLIAN static Eina_Bool -_efl_ui_progressbar_pulse_get(const Eo *obj EINA_UNUSED, Efl_Ui_Progressbar_Data *sd) +_efl_ui_progressbar_infinite_mode_get(const Eo *obj EINA_UNUSED, Efl_Ui_Progressbar_Data *sd) { return (sd->pulse_state && sd->pulse); } diff --git a/src/lib/elementary/efl_ui_progressbar.eo b/src/lib/elementary/efl_ui_progressbar.eo index 7166d8ee44..1bc55057f3 100644 --- a/src/lib/elementary/efl_ui_progressbar.eo +++ b/src/lib/elementary/efl_ui_progressbar.eo @@ -4,14 +4,15 @@ class @beta Efl.Ui.Progressbar extends Efl.Ui.Layout_Base implements Efl.Ui.Rang { [[Elementary progressbar class]] methods { - @property pulse { - [[Start/stop a given progress bar "pulsing" animation, if its under that mode.]] + @property infinite_mode { + [[Start/stop a given progress bar "pulsing" animation, if this mode is enabled.]] set { } get { } values { - state: bool; [[$true, to start the pulsing animation, $false to stop it]] + state: bool; [[$true if the progressbar should animate infinitely, + $false if the progressbar should animate based on a fixed endpoint.]] } } @property show_progress_label { --
