zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2f8683ef41d69cda1dc299e1920958a7f414be38
commit 2f8683ef41d69cda1dc299e1920958a7f414be38 Author: SangHyeon Jade Lee <[email protected]> Date: Tue Dec 31 09:48:18 2019 -0500 evas: fix legacy evas_object_clip_unset for group object. Summary: evas_object_clip_unset was broken for group object in several month or year.. basically, evas_object_clip_unset(obj) efl_canvas_object_clipper_set(obj, NULL) is equal on efl_clip implements, but on the group object, we need to unclip the whole group children in efl_canvas_group_efl_canvas_object_clipper_set which was not performed by legacy clip_usnet API. Test Plan: try clip_unset(obj) and clipper_set(obj, NULL) in any group clipped case (i.e. scroller content) and see clip_unset is broken and fixed by patch. Reviewers: cedric, bu5hm4n, zmike Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D10984 --- src/lib/evas/canvas/evas_clip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/evas/canvas/evas_clip.c b/src/lib/evas/canvas/evas_clip.c index 476183d55d..210aa5fc7d 100644 --- a/src/lib/evas/canvas/evas_clip.c +++ b/src/lib/evas/canvas/evas_clip.c @@ -461,9 +461,7 @@ _clip_unset(Eo *eo_obj, Evas_Object_Protected_Data *obj) EAPI void evas_object_clip_unset(Evas_Object *eo_obj) { - Evas_Object_Protected_Data *obj = EVAS_OBJECT_DATA_SAFE_GET(eo_obj); - EVAS_OBJECT_DATA_ALIVE_CHECK(obj); - _clip_unset(eo_obj, obj); + efl_canvas_object_clipper_set(eo_obj, NULL); } static void --
