zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2170a993882f28637a6b628a414863f4c00ea846
commit 2170a993882f28637a6b628a414863f4c00ea846 Author: Yeongjong Lee <[email protected]> Date: Wed Feb 12 09:04:09 2020 -0500 elm_interface_scrollable: prevent calling APIs with NULL edje object Summary: Is is unnecessary to call edje_object_ functions if `edje_obj` is NULL. Also, It prevents printing 6 eo warnings ``` WRN<30343>:eo ../src/lib/eo/eo.c:644 _efl_object_call_resolve() NULL passed to function efl_layout_signal_emit(). ``` Test Plan: `EINA_LOG_LEVELS=eo:2 elementary_test` `EINA_LOG_LEVELS=eo:3 elementary_test -to focus` Reviewers: bu5hm4n, Jaehyun_Cho, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11315 --- src/lib/elementary/elm_interface_scrollable.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/elementary/elm_interface_scrollable.c b/src/lib/elementary/elm_interface_scrollable.c index 7130efbd94..f03ae31e63 100644 --- a/src/lib/elementary/elm_interface_scrollable.c +++ b/src/lib/elementary/elm_interface_scrollable.c @@ -4032,6 +4032,9 @@ _elm_interface_scrollable_reset_signals(Eo *obj EINA_UNUSED, Elm_Scrollable_Smar { sid->go_up = sid->go_down = sid->go_right = sid->go_left = EINA_FALSE; + if (!sid->edje_obj) + return; + edje_object_signal_emit(sid->edje_obj, "elm,action,hide,up", "elm"); edje_object_signal_emit(sid->edje_obj, "elm,action,hide,down", "elm"); edje_object_signal_emit(sid->edje_obj, "elm,action,hide,right", "elm"); --
