jsuya pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=2ba77c0a3387e530bd1d48184c9f73e318d85b13
commit 2ba77c0a3387e530bd1d48184c9f73e318d85b13 Author: JunsuChoi <[email protected]> Date: Fri Feb 14 16:26:52 2020 +0900 efl_ui_image : Avoid integral division Summary: Assigning a result of integral division to a double type variable is not useful for division calculation. Test Plan: N/A Reviewers: Hermet, YOhoho Reviewed By: YOhoho Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11344 --- src/lib/elementary/efl_ui_image.c | 2 +- src/lib/elementary/efl_ui_image_zoomable.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elementary/efl_ui_image.c b/src/lib/elementary/efl_ui_image.c index 1f6ba219d1..96d6b1abd5 100644 --- a/src/lib/elementary/efl_ui_image.c +++ b/src/lib/elementary/efl_ui_image.c @@ -1860,7 +1860,7 @@ _efl_ui_image_efl_player_playback_progress_get(const Eo *obj EINA_UNUSED, Efl_Ui if (sd->edje) efl_player_playback_progress_get(sd->img); else if (sd->frame_count > 1) - return sd->cur_frame / (sd->frame_count - 1); + return (double)sd->cur_frame / ((double)sd->frame_count - 1.0); return 0.0; } diff --git a/src/lib/elementary/efl_ui_image_zoomable.c b/src/lib/elementary/efl_ui_image_zoomable.c index 478dbb4117..f8b40d648b 100644 --- a/src/lib/elementary/efl_ui_image_zoomable.c +++ b/src/lib/elementary/efl_ui_image_zoomable.c @@ -3153,7 +3153,7 @@ _efl_ui_image_zoomable_efl_player_playback_progress_get(const Eo *obj EINA_UNUSE if (sd->edje) efl_player_playback_progress_get(sd->edje); else if (sd->frame_count > 1) - return sd->cur_frame / (sd->frame_count - 1); + return (double)sd->cur_frame / ((double)sd->frame_count - 1.0); return 0.0; } --
