bu5hm4n pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=670cfb14fcf03ba25221c630d5237750cca52acb
commit 670cfb14fcf03ba25221c630d5237750cca52acb Author: Marcel Hollerbach <[email protected]> Date: Tue Mar 24 15:45:22 2020 +0100 eo: do not check this here as coverity points out, _obj_is_override is already dereferencing obj->opt so this was the wrong spot to check this. CID 1422014 CID 1422013 Reviewed-by: Stefan Schmidt <[email protected]> Differential Revision: https://phab.enlightenment.org/D11579 --- src/lib/eo/eo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/eo/eo.c b/src/lib/eo/eo.c index 63a73fae51..2bdf284f5f 100644 --- a/src/lib/eo/eo.c +++ b/src/lib/eo/eo.c @@ -1255,10 +1255,9 @@ _eo_free(_Eo_Object *obj, Eina_Bool manual_free EINA_UNUSED) } } #endif - if (_obj_is_override(obj)) + if (obj->opt && _obj_is_override(obj)) { - if (obj->opt) - _vtable_free(obj->opt->vtable, &obj->klass->vtable); + _vtable_free(obj->opt->vtable, &obj->klass->vtable); EO_OPTIONAL_COW_SET(obj, vtable, NULL); } --
