bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=e8eb67a557485caaca3733ae66f4da4c36517134

commit e8eb67a557485caaca3733ae66f4da4c36517134
Author: Mike Blumenkrantz <zm...@samsung.com>
Date:   Tue Mar 17 12:02:23 2020 -0400

    ecore/audio: add ERR messages when trying to overwrite existing vio
    
    this probably causes a crash or a leak at some point
    
    Reviewed-by: Marcel Hollerbach <m...@marcel-hollerbach.de>
    Differential Revision: https://phab.enlightenment.org/D11526
---
 src/lib/ecore_audio/ecore_audio_obj_in.c  | 5 ++++-
 src/lib/ecore_audio/ecore_audio_obj_out.c | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/lib/ecore_audio/ecore_audio_obj_in.c 
b/src/lib/ecore_audio/ecore_audio_obj_in.c
index b2a8f912c3..dcb792c8af 100644
--- a/src/lib/ecore_audio/ecore_audio_obj_in.c
+++ b/src/lib/ecore_audio/ecore_audio_obj_in.c
@@ -155,7 +155,10 @@ _ecore_audio_in_ecore_audio_vio_set(Eo *eo_obj, 
Ecore_Audio_Input *obj, Ecore_Au
   Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS);
 
   if (ea_obj->vio)
-    _free_vio(ea_obj);
+    {
+       ERR("VIO already set!");
+       _free_vio(ea_obj);
+    }
 
   obj->seekable = obj->seekable_prev;
 
diff --git a/src/lib/ecore_audio/ecore_audio_obj_out.c 
b/src/lib/ecore_audio/ecore_audio_obj_out.c
index 7e1d39beca..4c05b218da 100644
--- a/src/lib/ecore_audio/ecore_audio_obj_out.c
+++ b/src/lib/ecore_audio/ecore_audio_obj_out.c
@@ -118,7 +118,10 @@ _ecore_audio_out_ecore_audio_vio_set(Eo *eo_obj, 
Ecore_Audio_Output *_pd EINA_UN
   Ecore_Audio_Object *ea_obj = efl_data_scope_get(eo_obj, ECORE_AUDIO_CLASS);
 
   if (ea_obj->vio)
-    _free_vio(ea_obj);
+    {
+       ERR("VIO already set!");
+       _free_vio(ea_obj);
+    }
 
   if (!vio)
     return;

-- 


Reply via email to