stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=830d45e384b79690a27486c28822431efd6d09e2

commit 830d45e384b79690a27486c28822431efd6d09e2
Author: Marcel Hollerbach <[email protected]>
Date:   Fri Mar 27 18:11:07 2020 +0100

    exactness: do not efl_del the evas
    
    there is no need to do that, more than that. This is super dangerous,
    the display and connection ptr of x are passed from ecore_evas to evas,
    if you delete evas before ecore_evas, the later ecore_evas deletion will
    destroy the x connection which calls some functions in evas, which is
    already freed, which leads to a crash.
    
    Reviewed-by: Stefan Schmidt <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D11617
---
 src/bin/exactness/exactness.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/bin/exactness/exactness.c b/src/bin/exactness/exactness.c
index 3a9b8cde5c..79fefa8330 100644
--- a/src/bin/exactness/exactness.c
+++ b/src/bin/exactness/exactness.c
@@ -151,7 +151,6 @@ _exu_imgs_unpack(const char *exu_path, const char *dir, 
const char *ent_name)
           }
         efl_del(o);
      }
-   efl_del(e);
    ecore_evas_free(ee);
 }
 

-- 


Reply via email to