woohyun pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b79b3eea00c7f7d7cd3268df4fc1bb8b5f66444e

commit b79b3eea00c7f7d7cd3268df4fc1bb8b5f66444e
Author: Shinwoo Kim <[email protected]>
Date:   Mon Apr 13 11:17:19 2020 +0900

    elm_atspi_bridge: fix memory leak
    
    Summary:
    Dynamic memory is allocated by calling function
    'eldbus_message_iter_container_new' and lost by returning without free.
    
    Reviewers: Hermet, woohyun, jsuya, herb
    
    Subscribers: cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D11688
---
 src/lib/elementary/elm_atspi_bridge.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/elementary/elm_atspi_bridge.c 
b/src/lib/elementary/elm_atspi_bridge.c
index 0693fdb22a..ff0f35e102 100644
--- a/src/lib/elementary/elm_atspi_bridge.c
+++ b/src/lib/elementary/elm_atspi_bridge.c
@@ -1644,6 +1644,7 @@ _text_attributes_get(const Eldbus_Service_Interface 
*iface, const Eldbus_Message
      }
    else
      {
+        eldbus_message_iter_container_close(iter, iter_array);
         goto fail;
      }
 
@@ -1706,6 +1707,7 @@ _text_default_attributes_get(const 
Eldbus_Service_Interface *iface, const Eldbus
    else
      {
         eldbus_message_unref(ret);
+        eldbus_message_iter_container_close(iter, iter_array);
         return _dbus_invalid_ref_error_new(msg);
      }
 

-- 


Reply via email to