raster pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=5f93f16b61c34b09f9ce3f1ab7bb8473a81b4d04
commit 5f93f16b61c34b09f9ce3f1ab7bb8473a81b4d04 Author: Carsten Haitzler (Rasterman) <[email protected]> Date: Fri Apr 17 12:14:19 2020 +0100 ecore - proc env - fix values return NULL case - coverity this fixes CID 1419857 --- src/lib/ecore/efl_core_proc_env.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/lib/ecore/efl_core_proc_env.c b/src/lib/ecore/efl_core_proc_env.c index 3b21015048..f693df25af 100644 --- a/src/lib/ecore/efl_core_proc_env.c +++ b/src/lib/ecore/efl_core_proc_env.c @@ -58,6 +58,8 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd) char **values; values = eina_str_split(*p, "=", 2); + if (!values) break; + efl_core_env_set(obj, values[0], values[1]); EINA_LIST_FOREACH(existing_keys, n, key) @@ -68,12 +70,8 @@ _sync(Efl_Core_Env *obj, Efl_Core_Proc_Env_Data *pd) break; } } - - if (values) - { - free(values[0]); - free(values); - } + free(values[0]); + free(values); } } EINA_LIST_FOREACH(existing_keys, n, key) --
