stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=66adfc97f6ff8b03b813fa59207de410ec34d600

commit 66adfc97f6ff8b03b813fa59207de410ec34d600
Author: Marcel Hollerbach <[email protected]>
Date:   Fri Apr 17 15:11:26 2020 +0200

    exactness-inspect: fix NULL access
    
    ii might be NULL so we should ensure it is not NULL to call item_select
    
    CID 1419865
    
    Reviewed-by: Stefan Schmidt <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D11720
---
 src/bin/exactness/inspect.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/bin/exactness/inspect.c b/src/bin/exactness/inspect.c
index 926f9810f5..115eab90cb 100644
--- a/src/bin/exactness/inspect.c
+++ b/src/bin/exactness/inspect.c
@@ -878,15 +878,19 @@ _comp_gl_selected_cb(void *data EINA_UNUSED, Evas_Object 
*gl EINA_UNUSED, void *
    if (vv->p1)
      {
         _Item_Info *ii = eina_hash_find(_item_infos_hash, &(vv->p1));
-        if (!ii || !ii->gl_item) _obj_item_realize(vv->p1);
-        elm_genlist_item_selected_set(ii->gl_item, EINA_TRUE);
+        if (!ii || !ii->gl_item)
+          _obj_item_realize(vv->p1);
+        else
+          elm_genlist_item_selected_set(ii->gl_item, EINA_TRUE);
      }
 
    if (vv->p2)
      {
         _Item_Info *ii = eina_hash_find(_item_infos_hash, &(vv->p2));
-        if (!ii || !ii->gl_item) _obj_item_realize(vv->p2);
-        elm_genlist_item_selected_set(ii->gl_item, EINA_TRUE);
+        if (!ii || !ii->gl_item)
+          _obj_item_realize(vv->p2);
+        else
+          elm_genlist_item_selected_set(ii->gl_item, EINA_TRUE);
      }
 }
 

-- 


Reply via email to