stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=000464c8424a17f2d22ebe54befd7a5190a1c538

commit 000464c8424a17f2d22ebe54befd7a5190a1c538
Author: Stefan Schmidt <[email protected]>
Date:   Fri Apr 17 13:35:38 2020 +0200

    exactness: remove unused code
    
    We no longer support the old .rec format and we can always expect the
    file to be exu. Coverity found this block to be always true so the else
    part could not be reached.
    
    CID: 1421996
    
    Reviewed-by: Marcel Hollerbach <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D11723
---
 src/bin/exactness/exactness.c | 22 ++++++----------------
 1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/src/bin/exactness/exactness.c b/src/bin/exactness/exactness.c
index c99fceeb99..715ad275be 100644
--- a/src/bin/exactness/exactness.c
+++ b/src/bin/exactness/exactness.c
@@ -218,10 +218,8 @@ _run_command_prepare(const List_Entry *ent, char *buf)
    Eina_Strbuf *sbuf;
    const char *base_dir;
    Eina_List *itr;
-   Eina_Bool is_exu;
    EINA_LIST_FOREACH(_base_dirs, itr, base_dir)
      {
-        is_exu = EINA_TRUE;
         sprintf(scn_path, "%s/%s.exu", base_dir, ent->name);
         if (ecore_file_exists(scn_path)) goto ok;
      }
@@ -241,20 +239,12 @@ ok:
          _stabilize_shots ? "--stabilize-shots " : "",
          scn_path
          );
-   if (is_exu)
-     {
-        if (_mode == RUN_PLAY)
-           eina_strbuf_append_printf(sbuf, "-o '%s/%s/%s.exu' ", _dest_dir, 
CURRENT_SUBDIR, ent->name);
-        if (_mode == RUN_INIT)
-           eina_strbuf_append_printf(sbuf, "-o '%s' ", scn_path);
-     }
-   else
-     {
-        if (_mode == RUN_PLAY)
-           eina_strbuf_append_printf(sbuf, "-o '%s/%s' ", _dest_dir, 
CURRENT_SUBDIR);
-        if (_mode == RUN_INIT)
-           eina_strbuf_append_printf(sbuf, "-o '%s/%s' ", _dest_dir, 
ORIG_SUBDIR);
-     }
+
+   if (_mode == RUN_PLAY)
+      eina_strbuf_append_printf(sbuf, "-o '%s/%s/%s.exu' ", _dest_dir, 
CURRENT_SUBDIR, ent->name);
+   if (_mode == RUN_INIT)
+      eina_strbuf_append_printf(sbuf, "-o '%s' ", scn_path);
+
    if (ent->command)
      {
         eina_strbuf_append(sbuf, "-- ");

-- 


Reply via email to