stefan pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=3614c4190d78ed3abce4b3e1e175342e6299a242
commit 3614c4190d78ed3abce4b3e1e175342e6299a242 Author: Marcel Hollerbach <[email protected]> Date: Sun Apr 26 17:29:09 2020 +0200 efl_fileselector_entry: do not crash on a invalid model something is happening during shutdown, when a fileselector was created before. This is ending up in a strcmp to a NULL ptr, which crashes, with the now, we ensure that we are not crashing anymore, when that is happning. TO solve this properly we should really fix the cause of a invalid model beeing returned, however, i do not feel compftable doing that so short before a release. Reviewed-by: Stefan Schmidt <[email protected]> Differential Revision: https://phab.enlightenment.org/D11762 --- src/lib/elementary/elc_fileselector_entry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elc_fileselector_entry.c b/src/lib/elementary/elc_fileselector_entry.c index 632f17385b..ff37e5b1d0 100644 --- a/src/lib/elementary/elc_fileselector_entry.c +++ b/src/lib/elementary/elc_fileselector_entry.c @@ -444,7 +444,7 @@ _elm_fileselector_entry_efl_ui_view_model_get(const Eo *obj, Elm_Fileselector_En free(sd->path); sd->path = elm_entry_markup_to_utf8(elm_object_text_get(sd->entry)); - if (!strcmp(sd->path, efl_io_model_path_get(bmodel))) + if (eina_streq(sd->path, efl_io_model_path_get(bmodel))) return bmodel; ret = efl_add_ref(efl_class_get(bmodel), (Eo*) obj, --
