hermet pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6196311ad7e4f6ceacee0d56c97df06aab8e0995
commit 6196311ad7e4f6ceacee0d56c97df06aab8e0995 Author: JunsuChoi <[email protected]> Date: Tue May 12 23:08:30 2020 +0900 Efl.Canvas.Object.Animation: Prevent crash when called .animation_pause_set. Summary: When call efl_canvas_object_animation_animation_pause_set, pd->in is freed by calling efl_canvas_object_animation_stop in _animator_cb. So when set pause_state, crash occurred This patch add null check to prevent null access. Test Plan: N/A Reviewers: Hermet, kimcinoo, herb, bu5hm4n Reviewed By: Hermet, bu5hm4n Subscribers: bu5hm4n, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11815 --- src/lib/evas/canvas/efl_canvas_object_animation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/evas/canvas/efl_canvas_object_animation.c b/src/lib/evas/canvas/efl_canvas_object_animation.c index 3069d067ba..a017f73b96 100644 --- a/src/lib/evas/canvas/efl_canvas_object_animation.c +++ b/src/lib/evas/canvas/efl_canvas_object_animation.c @@ -148,7 +148,7 @@ _efl_canvas_object_animation_animation_pause_set(Eo *obj, Efl_Canvas_Object_Anim _end(obj, pd); else _start(obj, pd,(pd->in->speed < 0) ? 1.0 - pd->in->progress : pd->in->progress); - pd->in->pause_state = pause; + if (pd->in) pd->in->pause_state = pause; } EOLIAN static Eina_Bool --
