stefan pushed a commit to branch efl-1.24. http://git.enlightenment.org/core/efl.git/commit/?id=e0e7101e8cde395b3d165786355061fc7664c561
commit e0e7101e8cde395b3d165786355061fc7664c561 Author: JunsuChoi <[email protected]> Date: Tue May 12 11:20:21 2020 -0400 Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents Summary: When call elm_check_add, theme_apply of layout is called and _efl_ui_check_legacy_efl_ui_widget_theme_apply is called. Then it calls the signal emit for the icon. this call is unnecessary. Test Plan: N/A Reviewers: akanad, Jaehyun_Cho, Hermet, YOhoho, zmike Reviewed By: zmike Subscribers: zmike, cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D11812 --- src/lib/elementary/efl_ui_check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/efl_ui_check.c b/src/lib/elementary/efl_ui_check.c index 1ac817e29f..cce98bf5a0 100644 --- a/src/lib/elementary/efl_ui_check.c +++ b/src/lib/elementary/efl_ui_check.c @@ -481,7 +481,7 @@ _efl_ui_check_legacy_efl_ui_widget_theme_apply(Eo *obj, void *_pd EINA_UNUSED) int_ret = efl_ui_widget_theme_apply(efl_super(obj, EFL_UI_CHECK_LEGACY_CLASS)); if (int_ret == EFL_UI_THEME_APPLY_ERROR_GENERIC) return int_ret; - _icon_signal_emit(obj); + if (efl_finalized_get(obj)) _icon_signal_emit(obj); return int_ret; } --
