stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b209bb051b16cfb5b20ac6070cd3400c46996388

commit b209bb051b16cfb5b20ac6070cd3400c46996388
Author: Stefan Schmidt <[email protected]>
Date:   Tue Jun 9 14:29:35 2020 +0200

    tests: evas: check fd being non -1 before using close()
    
    eina_file_mkstemp would return -1 in an error case. Make sure we check
    the return when clsoing here.
    
    CID: 1400790
    
    Reviewed-by: Christopher Michael <[email protected]>
    Differential Revision: https://phab.enlightenment.org/D11957
---
 src/tests/evas/evas_test_image.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/tests/evas/evas_test_image.c b/src/tests/evas/evas_test_image.c
index 7ee16048c8..8106a0869e 100644
--- a/src/tests/evas/evas_test_image.c
+++ b/src/tests/evas/evas_test_image.c
@@ -904,7 +904,8 @@ EFL_START_TEST(evas_object_image_map_unmap)
 
    // save file, verify its pixels
    fd = eina_file_mkstemp("/tmp/evas-test.XXXXXX.png", &tmp);
-   close(fd);
+   fail_if(fd <= 0);
+   fail_if(close(fd));
    if (efl_file_save(o, tmp, NULL, NULL))
      {
         Eina_Rw_Slice sorig, sdest;

-- 


Reply via email to