hermet pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=ed0c46fa3b915554474cb9b832fb56fb07666e34
commit ed0c46fa3b915554474cb9b832fb56fb07666e34
Author: Woochanlee <wc0917....@samsung.com>
Date: Thu Dec 24 11:47:03 2020 +0900
eo_base_class: Avoid useless memory alloc
Summary:
The pd->ext will be NULL when the target object on invalidate state or edje
object or isolated object etc..
In above case, If data is NULL and ext is not needed, it seems there is no
need to create a node.
Reviewers: raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D12206
---
src/lib/eo/eo_base_class.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
index c062833188..546b5d3999 100644
--- a/src/lib/eo/eo_base_class.c
+++ b/src/lib/eo/eo_base_class.c
@@ -362,6 +362,8 @@ _key_generic_set(const Eo *obj, Efl_Object_Data *pd, const
char *key, const void
}
}
}
+ else
+ if (!data) return NULL;
ext = _efl_object_extension_need(pd);
if (ext)
--
