devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=598b7a1be6f6e42b217c423c6dcdad8132a1a941

commit 598b7a1be6f6e42b217c423c6dcdad8132a1a941
Author: Christopher Michael <devilho...@comcast.net>
Date:   Thu Feb 25 09:11:17 2021 -0500

    elm_slider: Fix unchecked return value
    
    Small patch to check the return value of eina_value_get reported by
    Coverity
    
    Fixes CID1401061
---
 src/lib/elementary/elm_slider.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/elm_slider.c b/src/lib/elementary/elm_slider.c
index 6604c4c2fb..8d6f9871ec 100644
--- a/src/lib/elementary/elm_slider.c
+++ b/src/lib/elementary/elm_slider.c
@@ -1571,7 +1571,9 @@ _format_legacy_to_format_eo_cb(void *data, Eina_Strbuf 
*str, const Eina_Value va
    const Eina_Value_Type *type = eina_value_type_get(&value);
 
    if (type == EINA_VALUE_TYPE_DOUBLE)
-     eina_value_get(&value, &val);
+     {
+        if (!eina_value_get(&value, &val)) return EINA_FALSE;
+     }
 
    if (sfwd->format_cb)
      buf = sfwd->format_cb(val);

-- 


Reply via email to