Branch: refs/heads/master Home: https://github.com/phpmyadmin/phpmyadmin Commit: c7f37ee42ff10fe60dcd3f6184fb138a306b9377 https://github.com/phpmyadmin/phpmyadmin/commit/c7f37ee42ff10fe60dcd3f6184fb138a306b9377 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00
Changed paths: M src/Controllers/Database/StructureController.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Refactor StructureController::getDbInfo() and expand its test coverage Add unit tests for the previously untested paths of getDbInfo(): sort name mapping (including descending order and unknown sort columns), the tbl_group and tbl_type filters, and MaxTableList paging. Refactor getDbInfo() into three flat branches, replacing the string|false $groupWithSeparator juggling and the duplicated string checks. The sort name is now mapped with a match expression. The paging position is passed as an explicit parameter instead of being read from a private field, and the total table count is always returned as an int instead of int|null, so the caller no longer needs a fallback count. Signed-off-by: Kamil Tekiela <[email protected]> Co-Authored-By: Claude Fable 5 <[email protected]> Commit: fbf5158b2b16151a0308a987a0eec42cc6cf7ce3 https://github.com/phpmyadmin/phpmyadmin/commit/fbf5158b2b16151a0308a987a0eec42cc6cf7ce3 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M psalm-baseline.xml M src/Controllers/Database/StructureController.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Remove the position field from Database StructureController Signed-off-by: Kamil Tekiela <[email protected]> Co-Authored-By: Claude Fable 5 <[email protected]> Commit: 9b9ed5485b308628dae6548fd39b17aa885d3fae https://github.com/phpmyadmin/phpmyadmin/commit/9b9ed5485b308628dae6548fd39b17aa885d3fae Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M src/Controllers/Database/StructureController.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Fix table list position handling in Database StructureController Clamp negative pos parameters to 0 in getTableListPosition(); a negative value used to be stored in the session and end up as a negative array_slice() offset or an invalid negative SQL OFFSET. Redirect to the last page when the position is exactly equal to the total number of tables: such a page is empty, but the previous check only redirected when the position was strictly greater, rendering an empty table list for a non-empty database. Signed-off-by: Kamil Tekiela <[email protected]> Co-Authored-By: Claude Fable 5 <[email protected]> Commit: cb7a87d11572bf655e1deedfaabf00a2c1990ee4 https://github.com/phpmyadmin/phpmyadmin/commit/cb7a87d11572bf655e1deedfaabf00a2c1990ee4 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: A src/Dbal/TableType.php M src/Controllers/Database/StructureController.php M src/Dbal/DatabaseInterface.php M src/Query/Generator.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Introduce TableType enum for table list type filtering Signed-off-by: Kamil Tekiela <[email protected]> Co-Authored-By: Claude Fable 5 <[email protected]> Commit: 9b0cc2548ef70390f6b14f2a7b27b7e939ec8021 https://github.com/phpmyadmin/phpmyadmin/commit/9b0cc2548ef70390f6b14f2a7b27b7e939ec8021 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M phpstan-baseline.neon M psalm-baseline.xml M src/Controllers/Database/StructureController.php M src/Database/Designer/Common.php M src/Dbal/DatabaseInterface.php M src/Plugins/Export/ExportSql.php M src/Query/Generator.php M tests/unit/Controllers/Database/DataDictionaryControllerTest.php M tests/unit/Controllers/Database/MultiTableQuery/QueryControllerTest.php M tests/unit/Controllers/Database/StructureControllerTest.php M tests/unit/Controllers/Export/ExportControllerTest.php M tests/unit/Controllers/Operations/TableControllerTest.php M tests/unit/Database/Designer/CommonTest.php M tests/unit/Export/ExportTest.php M tests/unit/Plugins/Export/ExportSqlTest.php M tests/unit/SqlTest.php M tests/unit/Stubs/DbiDummy.php M tests/unit/Table/TableTest.php Log Message: ----------- Refactoring of getTablesFull Signed-off-by: Kamil Tekiela <[email protected]> Commit: a1490876266e64bd1e3e8cea252f354b31f1e300 https://github.com/phpmyadmin/phpmyadmin/commit/a1490876266e64bd1e3e8cea252f354b31f1e300 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M src/Dbal/DatabaseInterface.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Fix bug when fetching table groups Signed-off-by: Kamil Tekiela <[email protected]> Commit: b7a80e1a34a591c26bfd0a170c95f5120d3b95d1 https://github.com/phpmyadmin/phpmyadmin/commit/b7a80e1a34a591c26bfd0a170c95f5120d3b95d1 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M src/Dbal/DatabaseInterface.php Log Message: ----------- Maintain stable sort Signed-off-by: Kamil Tekiela <[email protected]> Commit: acdc86d776e1cf430f1fd88e27b8df82f71fda23 https://github.com/phpmyadmin/phpmyadmin/commit/acdc86d776e1cf430f1fd88e27b8df82f71fda23 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M psalm-baseline.xml M src/Dbal/DatabaseInterface.php Log Message: ----------- Simplify the sorting function Signed-off-by: Kamil Tekiela <[email protected]> Commit: 7c028e503350edf6660c22d317ef709bfff30156 https://github.com/phpmyadmin/phpmyadmin/commit/7c028e503350edf6660c22d317ef709bfff30156 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M phpstan-baseline.neon M src/Dbal/DatabaseInterface.php Log Message: ----------- Fix type hints Signed-off-by: Kamil Tekiela <[email protected]> Commit: 37d30c08bba59acb381f8be56e3ad11f3e0be623 https://github.com/phpmyadmin/phpmyadmin/commit/37d30c08bba59acb381f8be56e3ad11f3e0be623 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M src/Controllers/Database/StructureController.php Log Message: ----------- Change signature of getTablesWhenOpen Signed-off-by: Kamil Tekiela <[email protected]> Commit: 21e133ebc0206f78261b9d1221f20abe83fd88c8 https://github.com/phpmyadmin/phpmyadmin/commit/21e133ebc0206f78261b9d1221f20abe83fd88c8 Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M phpstan-baseline.neon M src/Controllers/Database/StructureController.php M src/Dbal/DatabaseInterface.php M src/Query/Generator.php M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Stop pinning table group to the top Signed-off-by: Kamil Tekiela <[email protected]> Commit: ccc28ce3facd9f51814a883e9efc3d4e33ce37ea https://github.com/phpmyadmin/phpmyadmin/commit/ccc28ce3facd9f51814a883e9efc3d4e33ce37ea Author: Kamil Tekiela <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) +01:00 Changed paths: M tests/unit/Controllers/Database/StructureControllerTest.php Log Message: ----------- Add tests for getDbInfo table group filtering Signed-off-by: Kamil Tekiela <[email protected]> Co-Authored-By: Claude Sonnet 5 <[email protected]> Commit: 9508038d9e6342fd2ff29ea68707360c87d732e2 https://github.com/phpmyadmin/phpmyadmin/commit/9508038d9e6342fd2ff29ea68707360c87d732e2 Author: Maurício Meneghini Fauth <[email protected]> Date: 2026-09-16 (Wed, 09 September 2026) -03:00 Changed paths: A src/Dbal/TableType.php M phpstan-baseline.neon M psalm-baseline.xml M src/Controllers/Database/StructureController.php M src/Database/Designer/Common.php M src/Dbal/DatabaseInterface.php M src/Plugins/Export/ExportSql.php M src/Query/Generator.php M tests/unit/Controllers/Database/DataDictionaryControllerTest.php M tests/unit/Controllers/Database/MultiTableQuery/QueryControllerTest.php M tests/unit/Controllers/Database/StructureControllerTest.php M tests/unit/Controllers/Export/ExportControllerTest.php M tests/unit/Controllers/Operations/TableControllerTest.php M tests/unit/Database/Designer/CommonTest.php M tests/unit/Export/ExportTest.php M tests/unit/Plugins/Export/ExportSqlTest.php M tests/unit/SqlTest.php M tests/unit/Stubs/DbiDummy.php M tests/unit/Table/TableTest.php Log Message: ----------- Merge pull request #20387 from kamil-tekiela/Refactoring-of-getDbInfo-and-getTablesFull Refactoring of getDbInfo and getTablesFull _______________________________________________ Git mailing list -- [email protected] To unsubscribe send an email to [email protected]
