On Sat, 2005-04-16 at 01:48 +0200, Petr Baudis wrote:
> Dear diary, on Thu, Apr 14, 2005 at 10:53:50AM CEST, I got a letter
> where Martin Schlemmer <[EMAIL PROTECTED]> told me that...
> > Hi,
> >
> > Might not be that an big an issue as it should be freed on exit, but
> > might cause problems with big trees.
> >
> > ----
> >
> > Plug memory leak in update-cache.c.
> >
> > Signed-off-by: Martin Schlemmer <[EMAIL PROTECTED]>
> >
> > update-cache.c: 22f3ccd47db4f0888901109a8cbf883d272d1cba
> > --- 22f3ccd47db4f0888901109a8cbf883d272d1cba/update-cache.c
> > +++ uncommitted/update-cache.c
> > @@ -202,6 +202,7 @@
> > printf("%s: needs update\n", ce->name);
> > continue;
> > }
> > + free(active_cache[i]);
> > active_cache[i] = new;
> > }
> > }
>
> FYI, new could've contained active_cache[i] at that time, so you needed
> to check for that. Fixed though, thanks for pointing it out.
> Urk, no, please drop. As Ingo pointed out, the memory was obtained via mmap ... -- Martin Schlemmer
signature.asc
Description: This is a digitally signed message part
