Dear diary, on Mon, Apr 18, 2005 at 05:23:34PM CEST, I got a letter
where Paul Jackson <[EMAIL PROTECTED]> told me that...
> Pasky,
> Looks like a couple of questions I asked over the weekend
> got lost along the way.

Yes, sorry about that; I had a lot of mail traffic lately and I'm not so
used to it. ;-)

>  1) How do you want me to fix the indentation on my patch
>     to optimize gitdiff-do script:
>       - forget my first patch and resend from scratch, or
>       - a second patch restoring indentation, on top of my first one.

Resend from scratch, please.

I cannot guarantee I will look at it immediately, though. Optimizing is
nice, but gitdiff-do's speed is already usable and there are much more
pressing issues for git-pasky right now.

>  2) Would you be interested in a patch that used a more robust tmp
>     file creation, along the lines of replacing
>           t=${TMPDIR:-/usr/tmp}/gitdiff.$$
>           trap 'set +f; rm -fr $t.?; trap 0; exit 0' 0 1 2 3 15
>     with:
>           tmp=${TMPDIR-/tmp}
>           tmp=$tmp/gitdiff-do.$RANDOM.$RANDOM.$RANDOM.$$
>           (umask 077 && mkdir $tmp) || {
>                   echo "Could not create temporary directory! Exiting." 1>&2 
>                   exit 1
>           }
>           trap 'rm -fr $tmp; trap 0; exit 0' 0 1 2 3 15
>           t=$tmp/tmp
>     From the link that Dave Jones provided, the
>     above $tmp directory is about as good as using mktemp, while
>     avoiding both dependency on mktemp options not everyone has.
>  3) If interested in (2), would you want it instead of my previous mktemp
>     removal patch, or on top of it?

Instead of the previous patch. But what I said still holds - this can go
in only after we have a shell library sharing the common functions - I
don't want to have this horrid stuff in every file.

Actually, if you will make a mktemp shell function, no changes
whatsoever might be needed to the other scripts.

                                Petr "Pasky" Baudis
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at

Reply via email to