>>>>> "DB" == Daniel Barkalow <[EMAIL PROTECTED]> writes:

DB> On Mon, 18 Apr 2005, Linus Torvalds wrote:
>> On Sun, 17 Apr 2005, Daniel Barkalow wrote:
>> >
>> > This series introduces common parsers for objects, and ports the programs
>> > that currently use revision.h to them.
>> > 
>> >  1: the header files
>> >  2: the implementations
>> >  3: port rev-tree
>> >  4: port fsck-cache
>> >  5: port merge-base
>> Ok, having now looked at the code, I don't have any objections at all. 

I was looking at the tree part and am thinking that it would
make it much nicer if your tree object records path for each
entry.  Currently it just borrows from object.refs to represent
its children, which is good enough for the applications listed
above (none of them would care where in the tree the object
belongs to), but I was thinking about an incremental dumper I
talked about in another thread and noticed that I cannot use the
current struct tree as is to compare two trees to find related
sha1 files (then I would inflate both, run diff and record the
output as a recipe to create one sha1 object from the other).

Or am I misreading the code that parses tree objects?

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to