On Fri, 22 Apr 2005, Junio C Hamano wrote:
> Almost, with a counter-example.  Please try this yourself:

I agree that what git outputs is always "based on the archive base". But 
that's an independent issue from "where is the working directory". That's 
the issue of "how do you want me to print out the results".

To see just how independent that is, think about how git-pasky (and,
indeed, standard "show-diff") already prints out the results in a
_different_ base than the working directory _or_ the base. Ie the way we 
already do

        --- a/Makefile
        +++ b/Makefile
        ... patch ...

for a patch to "Makefile" in the top-level directory.

IOW, showing pathnames is different from _using_ them. And if you were 
planning on using the same logic for both, you'd have been making a 
mistake in the first place.

To _use_ pathnames, you use "pwd". To _show_ them, you use some other
mechanism. You must not mix up those two issues, or you'd always get
"show-diff" wrong.

I actually think that showing the pathnames is up to the wrapper scripts. 
Git core really always just works on the "canonical" format.

(And I personally think that "show-diff" is really part of the "wrapper
scripts" around git. I wrote it originally just because I needed something
to verify the index file handling, not because it's "core" like the other
programs. I do _not_ consider "show-diff" to be part of the core git code,
really. Same goes for "git-export", btw - for the same reasons. It's not

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to