On Wed, Jul 06, 2005 at 01:37:55PM -0700, Linus Torvalds wrote:
>
>
> On Wed, 6 Jul 2005, Greg KH wrote:
> >
> > I just updated to the latest git tree, and now get the following when I
> > try to pull from a ssh repo:
> >
> > $ git-pull-script [EMAIL PROTECTED]:/public_html/udev.git/
> > fatal: I don't like '@'. Sue me.
> >
> > So I drop the @ and then get:
> > $ git-pull-script someserver.org:/public_html/udev.git/
> > fatal: I don't like '_'. Sue me.
>
> Heh. It really is personal.
>
> The new git-pack handling tries to avoid special characters, because it
> passes some things off to a shell (ie it opens up an ssh connection.
>
> But yeah, it's being a bit too anal. Just look at connect.c: shell_safe(),
> and add both '_' and '@' to the safe list (and any other safe characters),
> and off you go.
Ok, below is a patch for this. It works, but then errors out with:
bash: git-upload-pack: command not found
fatal: unexpected EOF
So I'm guessing that I have to convince the server owner to update their
version of git too?
thanks,
greg k-h
--------------------
Subject: allow _ and @ in addresses
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
diff --git a/connect.c b/connect.c
--- a/connect.c
+++ b/connect.c
@@ -57,6 +57,7 @@ static char *shell_safe(char *url)
['A'...'Z'] = 1,
['.'] = 1, ['/'] = 1,
['-'] = 1, ['+'] = 1,
+ ['@'] = 1, ['_'] = 1,
[':'] = 1
};
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
